Skip to content

fix(transformer): Allow camel-cased json tags #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix(transformer): Allow camel-cased json tags #828

merged 1 commit into from
Apr 28, 2023

Conversation

@candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Apr 28, 2023

Follow-up for #820

@github-actions github-actions bot added the fix label Apr 28, 2023
@candiduslynx candiduslynx requested a review from disq April 28, 2023 08:38
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

⏱️ Benchmark results

Comparing with 9c25670

  • DefaultConcurrencyDFS-2 resources/s: 10,647 ⬇️ 4.85% decrease vs. 9c25670
  • DefaultConcurrencyRoundRobin-2 resources/s: 10,913 ⬇️ 11.11% decrease vs. 9c25670
  • Glob-2 ns/op: 289.8 ⬆️ 17.53% increase vs. 9c25670
  • TablesWithChildrenDFS-2 resources/s: 22,033 ⬇️ 19.15% decrease vs. 9c25670
  • TablesWithChildrenRoundRobin-2 resources/s: 22,234 ⬇️ 10.97% decrease vs. 9c25670
  • TablesWithRateLimitingDFS-2 resources/s: 28.26 ⬆️ 0.25% increase vs. 9c25670
  • TablesWithRateLimitingRoundRobin-2 resources/s: 796 ⬇️ 4.81% decrease vs. 9c25670
  • BufferedScanner-2 ns/op: 12.74 ⬆️ 13.27% increase vs. 9c25670
  • LogReader-2 ns/op: 40.38 ⬆️ 10.33% increase vs. 9c25670

disq
disq approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@disq disq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9c25670) 47.18% compared to head (4b86fa7) 47.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   47.18%   47.18%           
=======================================
  Files          76       76           
  Lines        7845     7845           
=======================================
  Hits         3702     3702           
  Misses       3643     3643           
  Partials      500      500
Impacted Files Coverage Δ
transformers/struct.go 71.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@candiduslynx candiduslynx merged commit 653a50d into main Apr 28, 2023
@candiduslynx candiduslynx deleted the fix/name-transformer/check-after-transform branch April 28, 2023 09:16
@cq-bot cq-bot mentioned this pull request Apr 28, 2023
Merged
candiduslynx pushed a commit that referenced this pull request Apr 28, 2023
@cq-bot
chore(main): Release v2.5.1 (#829)
51697d2 
🤖 I have created a release *beep* *boop*
---


##
[2.5.1](v2.5.0...v2.5.1)
(2023-04-28)


### Bug Fixes

* **transformer:** Allow camel-cased json tags
([#828](#828))
([653a50d](653a50d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

+1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@candiduslynx @disq @yevgenypats