Skip to content

fix(transformer): Allow camel-cased json tags #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix(transformer): Allow camel-cased json tags #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions transformers/struct.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ func DefaultNameTransformer(field reflect.StructField) (string, error) {
if jsonTag == "-" {
return "", nil
}
if schema.ValidColumnName(jsonTag) {
name = jsonTag
if nameFromJSONTag := defaultCaser.ToSnake(jsonTag); schema.ValidColumnName(nameFromJSONTag) {
return nameFromJSONTag, nil
}
}
return defaultCaser.ToSnake(name), nil
Expand Down
7 changes: 6 additions & 1 deletion transformers/struct_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ type (
}

testFunnyStruct struct {
AFunnyLookingField string `json:"OS-EXT:a-funny-looking-field"`
AFunnyLookingField string `json:"OS-EXT:a-funny-looking-field"`
AFieldWithCamelCaseName string `json:"camelCaseName"`
}
)

Expand Down Expand Up @@ -255,6 +256,10 @@ var (
Name: "a_funny_looking_field",
Type: schema.TypeString,
},
{
Name: "camel_case_name",
Type: schema.TypeString,
},
},
}
)
Expand Down