fix(destination): Don't duplicate tables to be removed #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 47.38% 47.32% -0.06%
==========================================
Files 55 55
Lines 5044 5050 +6
==========================================
Hits 2390 2390
- Misses 2402 2408 +6
Partials 252 252
☔ View full report in Codecov by Sentry. |
hermanschaaf
approved these changes
May 17, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
The fix looks good, just one more update so the comment is in sync with the code
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
yevgenypats
approved these changes
May 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [3.5.2](v3.5.1...v3.5.2) (2023-05-18) ### Bug Fixes * **arrow:** `schema.Table` <-> `arrow.Schema` conversion ([#886](#886)) ([61d98c9](61d98c9)) * **destination:** Don't duplicate tables to be removed ([#886](#886)) ([61d98c9](61d98c9)) * **tables:** Flatten stripping relations ([#884](#884)) ([e890385](e890385)) * **testing:** CQ Parent ID column should not be NotNull ([#887](#887)) ([f4aa5bc](f4aa5bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(destination): Don't duplicate tables to be removed (#886)
fix(arrow):
schema.Table<->arrow.Schemaconversion (#886)END_COMMIT_OVERRIDE