Skip to content

fix: Handle PrimaryKeyComponents in packaging #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 31, 2024
Merged

fix: Handle PrimaryKeyComponents in packaging #1503

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b600f5c
initial
bbernays Jan 26, 2024
1dc48eb
Update scheduler_test.go
bbernays Jan 30, 2024
f195069
Update name from VirtualPK to PrimaryKeyComponents
bbernays Jan 30, 2024
732f484
Merge branch 'main' into virtual-pk
bbernays Jan 30, 2024
b99d629
Update package.go
bbernays Jan 31, 2024
62729e2
Merge branch 'main' into virtual-pk
bbernays Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions serve/package.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (

cloudquery_api "github.com/cloudquery/cloudquery-api-go"
"github.com/cloudquery/plugin-sdk/v4/plugin"
"github.com/cloudquery/plugin-sdk/v4/schema"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -80,8 +81,11 @@ func (s *PluginServe) writeTablesJSON(ctx context.Context, dir string) error {
Type: column.Type.String(),
IncrementalKey: column.IncrementalKey,
NotNull: column.NotNull,
PrimaryKey: column.PrimaryKey,
Unique: column.Unique,
// PrimaryKey Will be set to true Under the following conditions:
// 1. If the column is a `PrimaryKeyComponent`
// 2. If the column is a `PrimaryKey` and both of the following are true column name is NOT `_cq_id` and there are other columns that are a PrimaryKeyComponent
PrimaryKey: (column.PrimaryKey && !(column.Name == schema.CqIDColumn.Name && len(table.PrimaryKeyComponents()) > 0)) || column.PrimaryKeyComponent,
Unique: column.Unique,
})
}
tablesToEncode = append(tablesToEncode, cloudquery_api.PluginTableCreate{
Expand Down