Skip to content

fix: Only call newExecutionClient if needed #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023
Merged

fix: Only call newExecutionClient if needed #630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3399f
fix: Only call `newExecutionClient` if needed
erezrokah Jan 26, 2023
5aeb7e5
Merge branch 'main' into fix/only_call_newExecutionClient_if_needed
kodiakhq[bot] Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions plugins/source/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,12 @@ func (p *Plugin) Init(ctx context.Context, spec specs.Source) error {
return fmt.Errorf("unknown backend: %s", spec.Backend)
}

p.client, err = p.newExecutionClient(ctx, p.logger, spec, Options{Backend: p.backend})
if err != nil {
return fmt.Errorf("failed to create execution client for source plugin %s: %w", p.name, err)
}
tables := p.tables
if p.getDynamicTables != nil {
p.client, err = p.newExecutionClient(ctx, p.logger, spec, Options{Backend: p.backend})
if err != nil {
return fmt.Errorf("failed to create execution client for source plugin %s: %w", p.name, err)
}
tables, err = p.getDynamicTables(ctx, p.client)
if err != nil {
return fmt.Errorf("failed to get dynamic tables: %w", err)
Expand Down Expand Up @@ -272,6 +272,14 @@ func (p *Plugin) Sync(ctx context.Context, res chan<- *schema.Resource) error {
}
defer p.mu.Unlock()

if p.client == nil {
var err error
p.client, err = p.newExecutionClient(ctx, p.logger, p.spec, Options{Backend: p.backend})
if err != nil {
return fmt.Errorf("failed to create execution client for source plugin %s: %w", p.name, err)
}
}

startTime := time.Now()
switch p.spec.Scheduler {
case specs.SchedulerDFS:
Expand Down