Skip to content

fix: Better string methods for TableColumnChange #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: Better string methods for TableColumnChange #690

merged 1 commit into from
Feb 16, 2023

Conversation

@yevgenypats
Copy link
Contributor

@yevgenypats yevgenypats commented Feb 16, 2023

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions github-actions bot added the fix label Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Feb 16, 2023

⏱️ Benchmark results

Comparing with dc3bedf

  • DefaultConcurrencyDFS-2 resources/s: 11,521 ⬆️ 6.82% increase vs. dc3bedf
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,383 ⬆️ 1.03% increase vs. dc3bedf
  • Glob-2 ns/op: 200.9 ⬇️ 30.56% decrease vs. dc3bedf
  • TablesWithChildrenDFS-2 resources/s: 28,576 ⬆️ 3.68% increase vs. dc3bedf
  • TablesWithChildrenRoundRobin-2 resources/s: 27,244 ⬇️ 1.19% decrease vs. dc3bedf
  • TablesWithRateLimitingDFS-2 resources/s: 28.32 ⬇️ 0.04% decrease vs. dc3bedf
  • TablesWithRateLimitingRoundRobin-2 resources/s: 857 ⬆️ 4.29% increase vs. dc3bedf
  • BufferedScanner-2 ns/op: 9.41 ⬇️ 23.27% decrease vs. dc3bedf
  • LogReader-2 ns/op: 31.01 ⬇️ 19.19% decrease vs. dc3bedf

@kodiakhq kodiakhq bot merged commit a0ec52c into main Feb 16, 2023
@kodiakhq kodiakhq bot deleted the fix/string_changes branch February 16, 2023 13:42
@cq-bot cq-bot mentioned this pull request Feb 16, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Feb 16, 2023
@cq-bot
chore(main): Release v1.38.0 (#689)
ed36d27 
🤖 I have created a release *beep* *boop*
---


## [1.38.0](v1.37.1...v1.38.0) (2023-02-16)


### Features

* Improve migration detection APIs ([#688](#688)) ([dc3bedf](dc3bedf))


### Bug Fixes

* Better string methods for TableColumnChange ([#690](#690)) ([a0ec52c](a0ec52c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yevgenypats @erezrokah