Skip to content

feat(multiplex): Detect duplicated clients #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2023
Merged

feat(multiplex): Detect duplicated clients #723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c02c354
feat(multiplex): Detect multiple clients
erezrokah Mar 1, 2023
f555ca5
Merge branch 'main' into feat/detect_multiple_clients
kodiakhq[bot] Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plugins/source/scheduler_dfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ func (p *Plugin) syncDfs(ctx context.Context, spec specs.Source, client schema.C
if table.Multiplex != nil {
clients = table.Multiplex(client)
}
// Detect duplicate clients while multiplexing
seenClients := make(map[string]bool)
for _, c := range clients {
if _, ok := seenClients[c.ID()]; !ok {
seenClients[c.ID()] = true
} else {
sentry.WithScope(func(scope *sentry.Scope) {
scope.SetTag("table", table.Name)
sentry.CurrentHub().CaptureMessage("duplicate client ID in " + table.Name)
})
p.logger.Warn().Str("client", c.ID()).Str("table", table.Name).Msg("multiplex returned duplicate client")
}
}
preInitialisedClients[i] = clients
// we do this here to avoid locks so we initial the metrics structure once in the main goroutines
// and then we can just read from it in the other goroutines concurrently given we are not writing to it.
Expand Down