Skip to content

fix(arrow): Add missing table options #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2023
Merged

fix(arrow): Add missing table options #833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651ecb3
add missing table options
candiduslynx Apr 30, 2023
d5a30d8
Merge branch 'main' into fix/constraints-for-arrow-from-schema
kodiakhq[bot] May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions schema/arrow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ type MetadataFieldOptions struct {
}

type MetadataSchemaOptions struct {
TableName string
TableDescription string
TableName string
TableDescription string
TableIsIncremental bool
TablePKConstraint string
}

func NewSchemaMetadataFromOptions(opts MetadataSchemaOptions) arrow.Metadata {
Expand All @@ -95,6 +97,12 @@ func NewSchemaMetadataFromOptions(opts MetadataSchemaOptions) arrow.Metadata {
if opts.TableDescription != "" {
kv[MetadataTableDescription] = opts.TableDescription
}
if opts.TableIsIncremental {
kv[MetadataIncremental] = MetadataTrue
}
if opts.TablePKConstraint != "" {
kv[MetadataConstraintName] = opts.TablePKConstraint
}
return arrow.MetadataFrom(kv)
}

Expand Down Expand Up @@ -295,8 +303,10 @@ func CQSchemaToArrow(table *Table) *arrow.Schema {
fields = append(fields, CQColumnToArrowField(&col))
}
opts := MetadataSchemaOptions{
TableName: table.Name,
TableDescription: table.Description,
TableName: table.Name,
TableDescription: table.Description,
TableIsIncremental: table.IsIncremental,
TablePKConstraint: table.PkConstraintName,
}
metadata := NewSchemaMetadataFromOptions(opts)
return arrow.NewSchema(fields, &metadata)
Expand Down