Skip to content

feat: Add multi-label selection and Table metadata extraction#182

Merged
NathanZlion merged 12 commits intomainfrom
feat/pagescanner-additions
Jan 27, 2026
Merged

feat: Add multi-label selection and Table metadata extraction#182
NathanZlion merged 12 commits intomainfrom
feat/pagescanner-additions

Conversation

@NathanZlion
Copy link
Member

@NathanZlion NathanZlion commented Jan 20, 2026

Issue #, if available:

ybbPAl2KONnZ

  • Add LabelSelectionMode ('single' | 'multi') and extend analytics label handling to support multi-element label extraction, by treating metadata keys that end with "labels" as multi-labels; preserve "label" for single-labels.
  • Add table-specific metadata extraction when local metadata identifies an awsui.Table: properties.columnLabels, properties.selectedItemsLabels

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion changed the title Feat/pagescanner additions feat: Add multi-label selection and Table metadata extraction Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (c09d82c) to head (c6deda9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   99.00%   99.05%   +0.05%     
==========================================
  Files          42       42              
  Lines        1101     1165      +64     
  Branches      280      319      +39     
==========================================
+ Hits         1090     1154      +64     
+ Misses         11       10       -1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NathanZlion NathanZlion marked this pull request as ready for review January 21, 2026 09:19
@NathanZlion NathanZlion requested a review from a team as a code owner January 21, 2026 09:20
@NathanZlion NathanZlion removed the request for review from a team January 22, 2026 09:30
}
let labelElement: HTMLElement | null = node;

if (selectionMode === 'multi') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think splitting this code into a new method would make more sense: currently it's within processSingleLabel which is a bit confusing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even processLabel should be split into two methods too, overall I think it would make the code flow and typings more clear

@NathanZlion NathanZlion force-pushed the feat/pagescanner-additions branch from 0d46573 to 9701f1a Compare January 26, 2026 14:46
@NathanZlion NathanZlion enabled auto-merge January 27, 2026 14:18
@NathanZlion NathanZlion disabled auto-merge January 27, 2026 14:33
@NathanZlion NathanZlion enabled auto-merge January 27, 2026 14:36
@NathanZlion NathanZlion added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 1d5daa7 Jan 27, 2026
65 of 82 checks passed
@NathanZlion NathanZlion deleted the feat/pagescanner-additions branch January 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants