generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 204
feat: Support secondaryText and labelTag for button-dropdown #3844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cansuaa
merged 43 commits into
cloudscape-design:main
from
kuahuu:button-dropdown-secondaryText-labelTags-and-description-deprecation
Nov 19, 2025
Merged
feat: Support secondaryText and labelTag for button-dropdown #3844
cansuaa
merged 43 commits into
cloudscape-design:main
from
kuahuu:button-dropdown-secondaryText-labelTags-and-description-deprecation
Nov 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3844 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 861 861
Lines 25207 25213 +6
Branches 9098 9103 +5
=======================================
+ Hits 24450 24456 +6
Misses 710 710
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cansuaa
reviewed
Sep 15, 2025
…description-deprecation
cansuaa
reviewed
Sep 16, 2025
cansuaa
reviewed
Sep 16, 2025
Contributor
Author
|
Rebased from the latest origin main and resolve the conflict. |
cansuaa
reviewed
Sep 29, 2025
timogasda
previously requested changes
Oct 10, 2025
This reverts commit f43c798.
…description-deprecation
…description-deprecation
…description-deprecation
cansuaa
reviewed
Nov 11, 2025
cansuaa
reviewed
Nov 13, 2025
cansuaa
reviewed
Nov 13, 2025
…description-deprecation
…he disabled items with less secondary text and label tag
cansuaa
reviewed
Nov 14, 2025
pan-kot
previously approved these changes
Nov 19, 2025
pan-kot
approved these changes
Nov 19, 2025
Merged
via the queue into
cloudscape-design:main
with commit Nov 19, 2025
36c2502
137 of 139 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for secondaryText and labelTag properties to ButtonDropdown items, enabling richer item content similar to other Cloudscape components like Select and Multiselect.
This PR also added deprecated annotation for
descriptionprop for button dropdown item.New features:
secondaryText: Displays additional descriptive text below the main item text
labelTag: Adds a visual tag/label to items for categorization or status indication
Implementation details:
deprecatedannotation into thedescriptionpropfindSecondaryTextandfindLabelTagtest utilsRelated links, issue #, if available: n/a
How has this been tested?
Unit Tests:
Manual Testing:
Reviewers can test by running:
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.