-
Notifications
You must be signed in to change notification settings - Fork 204
feat: Add radio button component to Core #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
815a634 to
4970622
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 861 862 +1
Lines 25220 25223 +3
Branches 9107 9107
=======================================
+ Hits 24463 24466 +3
Misses 751 751
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4970622 to
37f7c96
Compare
37f7c96 to
e71d7b6
Compare
e71d7b6 to
6b1cabe
Compare
6b1cabe to
0130656
Compare
11ba51b to
fc17742
Compare
fc17742 to
02a263f
Compare
02a263f to
2f037ee
Compare
2f037ee to
0b0cc72
Compare
2c3949b to
7bd1889
Compare
This reverts commit 9536cf1.
3b07619 to
b9f40e5
Compare
| } | ||
|
|
||
| export type Ref = RadioButtonProps.Ref; | ||
| export interface Ref { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicating this instead of importing from RadioButton because for some reason, the Typescript generation of type declarations would import the top-level RadioButtonProps import instead of the internal one, causing the Console build to break.
Description
Related docs:
8an0ABGr7q2G,K9fjAlBZGYzg,8oBCA2XxSDHBHow has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.