Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Sep 15, 2025

Description

Related docs: 8an0ABGr7q2G, K9fjAlBZGYzg, 8oBCA2XxSDHB

How has this been tested?

  • Unit tests
  • Integration tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals force-pushed the feat/core-radio-button-component branch 4 times, most recently from 815a634 to 4970622 Compare September 15, 2025 16:06
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (ec8adf6) to head (c8199e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3860   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         861      862    +1     
  Lines       25220    25223    +3     
  Branches     9107     9107           
=======================================
+ Hits        24463    24466    +3     
  Misses        751      751           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals force-pushed the feat/core-radio-button-component branch from 4970622 to 37f7c96 Compare September 15, 2025 20:37
@jperals jperals force-pushed the feat/core-radio-button-component branch from 37f7c96 to e71d7b6 Compare September 16, 2025 05:18
@jperals jperals force-pushed the feat/core-radio-button-component branch from e71d7b6 to 6b1cabe Compare September 16, 2025 10:30
@jperals jperals force-pushed the feat/core-radio-button-component branch from 6b1cabe to 0130656 Compare September 16, 2025 14:30
@jperals jperals force-pushed the feat/core-radio-button-component branch 2 times, most recently from 11ba51b to fc17742 Compare September 16, 2025 15:28
@jperals jperals force-pushed the feat/core-radio-button-component branch from fc17742 to 02a263f Compare September 16, 2025 16:41
@jperals jperals force-pushed the feat/core-radio-button-component branch from 02a263f to 2f037ee Compare September 17, 2025 07:14
@jperals jperals force-pushed the feat/core-radio-button-component branch from 2f037ee to 0b0cc72 Compare September 17, 2025 15:45
@jperals jperals force-pushed the feat/core-radio-button-component branch 4 times, most recently from 2c3949b to 7bd1889 Compare September 25, 2025 08:31
@jperals jperals force-pushed the feat/core-radio-button-component branch from 3b07619 to b9f40e5 Compare November 19, 2025 16:17
@jperals jperals requested a review from pan-kot November 19, 2025 16:24
}

export type Ref = RadioButtonProps.Ref;
export interface Ref {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating this instead of importing from RadioButton because for some reason, the Typescript generation of type declarations would import the top-level RadioButtonProps import instead of the internal one, causing the Console build to break.

@jperals jperals enabled auto-merge November 19, 2025 16:45
@jperals jperals added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@jperals jperals added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 19, 2025
@pan-kot pan-kot added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@jperals jperals added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 485a7c9 Nov 19, 2025
50 checks passed
@jperals jperals deleted the feat/core-radio-button-component branch November 19, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants