generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 204
fix: prevent list item jump on hover in virtual scrolling #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6db7bbf to
fa520a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 854 854
Lines 24991 24993 +2
Branches 8806 8806
=======================================
+ Hits 24285 24287 +2
Misses 658 658
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa520a7 to
30a2f4f
Compare
4b4b72c to
b9fadb0
Compare
abdhalees
approved these changes
Oct 22, 2025
fix: inconsistent dropdown styling with virtual scroll refactor: deduplicate code
- Each item is shifted up by its index in pixels - The layout strut height is reduced by the number of items to account for the cumulative overlap
11b4e68 to
eb5ce9a
Compare
Who-is-PS
approved these changes
Oct 22, 2025
YueyingLu
pushed a commit
that referenced
this pull request
Nov 18, 2025
)" This reverts commit 2f763cb.
jperals
pushed a commit
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With virtual scrolling enabled, selectable items would "jump" on hover/selection due to border width changes (AWSUI-61303). Virtual scrolling positions items absolutely, so when border width changes from 1px to 2px on hover, the browser recalculates layout dimensions causing visible position shifts.
Additionally, option groups were missing the separating top border.
The solution uses box-shadows when virtual scrolling is enabled to simulate thick borders while maintaining thin actual borders. An alternative solution of making all borders the same thickness (hover / non-hover) would change the visual appearance compared to how it's supposed to look.
In summary:
How has this been tested?
Changes ran through screenshot test and have been verified locally.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.