Skip to content

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Nov 3, 2025

Description

Extends the textarea component with a style API for customization, allowing developers to override default component styles.

Related links, issue #, if available: n/a

How has this been tested?

  • Added unit tests for style prop validation and CSS class application
  • Screenshot tests passed without visual regressions
  • Added screenshot test coverage for pseudo selector style combinations (e.g., focus + hover) (CR-232301442)
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (a59c74f) to head (078fd30).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4001   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files         858      859    +1     
  Lines       25359    25404   +45     
  Branches     9014     9052   +38     
=======================================
+ Hits        24650    24695   +45     
- Misses        660      703   +43     
+ Partials       49        6   -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

</ScreenshotArea>

<div style={{ display: 'flex', gap: '10px', flexWrap: 'wrap', marginTop: '20px' }}>
<button id="toggle-styling" onClick={() => setCustomStyling(!customStyling)} type="button">
Copy link
Member

@georgylobko georgylobko Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocking] You can use the toggle button component instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@mxschll mxschll added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
@mxschll mxschll added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 5727a40 Nov 4, 2025
50 checks passed
@mxschll mxschll deleted the schomax/style-api-textarea branch November 4, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants