Skip to content

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Nov 19, 2025

Description

Extends the text filter component with a style API for customization, allowing developers to override default component styles.

Related links, issue #, if available: n/a

How has this been tested?

  • Added unit tests for style prop validation and CSS class application
  • Screenshot tests passed without visual regressions
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (f796951) to head (7b5144a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
+ Coverage   97.00%   97.12%   +0.11%     
==========================================
  Files         862      863       +1     
  Lines       25290    25292       +2     
  Branches     9123     9120       -3     
==========================================
+ Hits        24532    24564      +32     
+ Misses        752      681      -71     
- Partials        6       47      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll changed the title feat: implement style api for tabs component feat: implement style api for text filter component Nov 19, 2025
@mxschll mxschll force-pushed the dev-v3-schomax-text-filter branch from cabdfba to 67fe2fd Compare November 19, 2025 15:12
@mxschll mxschll marked this pull request as ready for review November 19, 2025 15:13
@mxschll mxschll requested a review from a team as a code owner November 19, 2025 15:13
@mxschll mxschll requested review from cansuaa and removed request for a team November 19, 2025 15:13
[customCssProps.stylePlaceholderFontStyle]: style?.placeholder?.fontStyle,
};

return properties;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see slightly different implementations in styles.tsx files. E.g. in prompt input we filter out the undefined values, why aren't we doing the same here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea because of this comment: #4025 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then we should remove that logic from prompt input as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll open a subsequent PR for that if that's ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also in the PR linked I don't see matchSnapshot being used but it is used here. Why are there different implementations? Let's have consistency across these similar implementations

@mxschll mxschll force-pushed the dev-v3-schomax-text-filter branch from 67fe2fd to 8606da3 Compare November 20, 2025 13:27
@mxschll mxschll added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 33e0333 Nov 20, 2025
50 checks passed
@mxschll mxschll deleted the dev-v3-schomax-text-filter branch November 20, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants