Skip to content

Conversation

@cansuaa
Copy link
Member

@cansuaa cansuaa commented Nov 21, 2025

Description

Take connector line's width into account while calculating its position for a more correct placement

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner November 21, 2025 10:15
@cansuaa cansuaa requested review from NathanZlion and removed request for a team November 21, 2025 10:15
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (7db92cc) to head (7e2f043).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4062      +/-   ##
==========================================
+ Coverage   96.99%   97.12%   +0.12%     
==========================================
  Files         862      863       +1     
  Lines       25223    25295      +72     
  Branches     9108     9120      +12     
==========================================
+ Hits        24466    24567     +101     
+ Misses        710      681      -29     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cansuaa cansuaa added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2025
@cansuaa cansuaa added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 0c4c33e Nov 21, 2025
84 of 85 checks passed
@cansuaa cansuaa deleted the cansua/connector-line-position branch November 21, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants