Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Nov 21, 2025

Description

For the system tag to be extracted by Documenter, the comment needs to be above the export statement.

How has this been tested?

  • Updated the snapshot with npm run build && npx jest -c jest.unit.config.js -u src/__tests__/snapshot-tests/documenter.test.ts (part of this PR diff)
  • Building the change in my website pipeline to make sure the website doesn't break: 7609312490
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (0c4c33e) to head (0c3c5b7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4063   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         863      863           
  Lines       25294    25294           
  Branches     9119     9119           
=======================================
  Hits        24566    24566           
  Misses        722      722           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals added this pull request to the merge queue Nov 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025
@jperals jperals added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit 4e7f8f3 Nov 24, 2025
52 checks passed
@jperals jperals deleted the fix/icon-provider-system-tag branch November 24, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants