Skip to content

fix: Patch Screan reader issue in multiselect selected items#4199

Merged
NathanZlion merged 3 commits intomainfrom
dev-v3-natidere-multiselect-a11y-fix
Feb 9, 2026
Merged

fix: Patch Screan reader issue in multiselect selected items#4199
NathanZlion merged 3 commits intomainfrom
dev-v3-natidere-multiselect-a11y-fix

Conversation

@NathanZlion
Copy link
Member

@NathanZlion NathanZlion commented Jan 22, 2026

Description

Fixed MultiSelect component accessibility issue where screen readers incorrectly announced "not-selected" for all options, including those that were actually selected. This prevented users relying on assistive technology from distinguishing between selected and unselected options.

  • Added aria-multiselectable="true"__ to the listbox element when in multiselect mode
  • Added both aria-selected attributes to multiselect options
  • Retained selectedAriaLabel in live region announcements AWSUI-61639

Related links, issue #, if available: n/a
AWSUI-61639

How has this been tested?

  • Tested with VoiceOver (macOS) - announcements work correctly, no more "not selected" false announcements
  • Done tests for MAC as well with the help of A11Y team, that's how we decided to keep the aria-live region selectedAriaLabel because NVDA and early version of JAWS (e.g. 2022, which is still pretty commonly used) have a bug around announcing the selected state.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.16%. Comparing base (0f8232f) to head (10e89c8).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/select/parts/virtual-list.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4199   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files         878      879    +1     
  Lines       25716    25750   +34     
  Branches     9297     9305    +8     
=======================================
+ Hits        24985    25019   +34     
+ Misses        725      684   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (825e839) to head (401a6c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4199   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         886      886           
  Lines       25996    25998    +2     
  Branches     9416     9418    +2     
=======================================
+ Hits        25267    25269    +2     
  Misses        682      682           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NathanZlion NathanZlion force-pushed the dev-v3-natidere-multiselect-a11y-fix branch from 566116e to 513c8e9 Compare January 27, 2026 11:58
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-multiselect-a11y-fix branch from 513c8e9 to 0d31f7e Compare January 29, 2026 15:55
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-multiselect-a11y-fix branch from 0d31f7e to d19d637 Compare February 3, 2026 17:22
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-multiselect-a11y-fix branch from d19d637 to d465e97 Compare February 3, 2026 18:48
@NathanZlion NathanZlion marked this pull request as ready for review February 4, 2026 08:54
@NathanZlion NathanZlion requested a review from a team as a code owner February 4, 2026 08:54
@NathanZlion NathanZlion removed the request for review from a team February 4, 2026 08:54
@NathanZlion NathanZlion requested a review from SpyZzey February 4, 2026 16:52
@SpyZzey SpyZzey force-pushed the dev-v3-natidere-multiselect-a11y-fix branch from e0a7338 to 401a6c5 Compare February 9, 2026 09:29
@NathanZlion NathanZlion added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit 9a1b7c5 Feb 9, 2026
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants