Skip to content

feat: Add disabled filter option to test utils to button-dropdown#4244

Merged
Who-is-PS merged 3 commits intomainfrom
dev-v3-philosr-button-dropdown-test
Feb 13, 2026
Merged

feat: Add disabled filter option to test utils to button-dropdown#4244
Who-is-PS merged 3 commits intomainfrom
dev-v3-philosr-button-dropdown-test

Conversation

@Who-is-PS
Copy link
Member

Description

Add { disabled?: boolean } filter option to findItems() and findItemById() test utils for ButtonDropdown. Follows the same pattern as TreeView's findItems({ expanded?: boolean }).

Related links, issue #, if available: AWSUI-61729

How has this been tested?

Unit tests added in src/button-dropdown/tests/button-dropdown-items.test.tsx

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (40696d3) to head (e8fea4a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4244   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         886      886           
  Lines       26017    26029   +12     
  Branches     9431     9438    +7     
=======================================
+ Hits        25287    25299   +12     
  Misses        683      683           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Who-is-PS Who-is-PS marked this pull request as ready for review February 12, 2026 14:24
@Who-is-PS Who-is-PS requested a review from a team as a code owner February 12, 2026 14:24
@Who-is-PS Who-is-PS requested review from pan-kot and taheramr and removed request for a team and taheramr February 12, 2026 14:24
pan-kot
pan-kot previously approved these changes Feb 12, 2026
@Who-is-PS Who-is-PS added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 5322337 Feb 13, 2026
85 of 86 checks passed
@Who-is-PS Who-is-PS deleted the dev-v3-philosr-button-dropdown-test branch February 13, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants