fix: Time input placeholder to respect timeInputFormat for date-range-picker#4246
Merged
fix: Time input placeholder to respect timeInputFormat for date-range-picker#4246
Conversation
| }); | ||
| }); | ||
|
|
||
| describe('time input placeholder', () => { |
Member
There was a problem hiding this comment.
suggest testing hour-only as well, for completeness
Member
Author
There was a problem hiding this comment.
True, added hour-only test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 886 886
Lines 26017 26021 +4
Branches 9431 9434 +3
=======================================
+ Hits 25287 25291 +4
Misses 683 683
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gethinwebster
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Time input placeholder now derives from the i18n
timePlaceholdervalue based ontimeInputFormat. Previously, using i18n support caused the full placeholder (e.g.,hh:mm:ss) to always display regardless of the format setting.timeInputFormat="hh:mm:ss"→"HH:MM:SS"(full)timeInputFormat="hh:mm"→"HH:MM"(truncated)timeInputFormat="hh"→"HH"(truncated)Related links, issue #, if available: n/a
How has this been tested?
Added test to verify truncation with non-English placeholder.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.