Skip to content

feat: Adjust inline Token elements to render spans instead of divs#4366

Merged
ernst-dev merged 2 commits intomainfrom
micro-pr/token-inline-span
Mar 20, 2026
Merged

feat: Adjust inline Token elements to render spans instead of divs#4366
ernst-dev merged 2 commits intomainfrom
micro-pr/token-inline-span

Conversation

@ernst-dev
Copy link
Member

Description

Swaps the element tags depending on variant so that inline Token elements use spans.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ernst-dev ernst-dev requested a review from pan-kot March 20, 2026 15:14
@ernst-dev ernst-dev requested a review from a team as a code owner March 20, 2026 15:14
@ernst-dev ernst-dev enabled auto-merge March 20, 2026 15:36
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (6082b18) to head (d262735).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4366   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         902      902           
  Lines       26468    26469    +1     
  Branches     9539     9541    +2     
=======================================
+ Hits        25794    25795    +1     
+ Misses        668      631   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ernst-dev ernst-dev added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@ernst-dev ernst-dev added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit c5eb583 Mar 20, 2026
49 checks passed
@ernst-dev ernst-dev deleted the micro-pr/token-inline-span branch March 20, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants