feat: add label and typography design tokens#4533
Merged
Merged
Conversation
mxschll
force-pushed
the
dev-v3-schomax-label-tokens
branch
from
e94017e to
99c24c1
Compare
mxschll
force-pushed
the
dev-v3-schomax-label-tokens
branch
from
99c24c1 to
3b86ffe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4533 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 939 939
Lines 29645 29645
Branches 10771 10771
=======================================
Hits 28883 28883
Misses 755 755
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mxschll
requested review from
at-susie and
srungta08
and removed request for
a team
mxschll
commented
May 18, 2026
| | 'fontSizeBodyM' | ||
| | 'fontSizeBodyS' | ||
| | 'fontSizeDisplayL' | ||
| | 'fontSizeHeadingXl' |
Member
Author
There was a problem hiding this comment.
I had the urge to sort the entries. It moved down.
mxschll
commented
May 18, 2026
| | 'fontSizeTabs' | ||
| | 'fontSmoothingMozOsx' | ||
| | 'fontSmoothingWebkit' | ||
| | 'fontSizeTabs' |
Member
Author
There was a problem hiding this comment.
Same here, order changed.
mxschll
commented
May 18, 2026
| fontSizeBodyM: '14px', | ||
| fontSizeBodyS: '12px', | ||
| fontSizeDisplayL: '42px', | ||
| fontSizeHeadingXl: '24px', |
srungta08
approved these changes
May 19, 2026
at-susie
reviewed
May 19, 2026
| colorTextFormLabel: { description: 'Component specific: Special because control group is different.' }, | ||
| colorTextFormLabel: { | ||
| description: 'The color of form field labels.', | ||
| public: false, |
Member
There was a problem hiding this comment.
Again, why not publicly themeable?
Member
Author
There was a problem hiding this comment.
Do we want it to be public for now? It's still possible to use them, they're just not public API in case we want to change something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce themeable tokens for labels and typography:
fontWeightBreadcrumbCurrentfontSizeFormLabel,lineHeightFormLabel,fontWeightFormLabel,colorTextFormLabelfontSizeKeyValuePairsLabel,lineHeightKeyValuePairsLabel,fontWeightKeyValuePairsLabelRelated links, issue #, if available: n/a
How has this been tested?
Green pipeline.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.