Skip to content

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Nov 14, 2022

Description

  • Added clearAriaLabel (or variations in context, like filteringClearAriaLabel and inContextInputClearAriaLabel) to all components that use a search input.
  • Restored the tab stop for clear buttons.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot force-pushed the fix-input-clear branch 8 times, most recently from 149988e to a6cfe74 Compare November 17, 2022 13:13
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 92.97% // Head: 92.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e11f166) compared to base (d52870f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         574      574           
  Lines       16766    16769    +3     
  Branches     4628     4627    -1     
=======================================
+ Hits        15588    15591    +3     
  Misses       1101     1101           
  Partials       77       77           
Impacted Files Coverage Δ
src/autosuggest/internal.tsx 95.23% <ø> (ø)
src/property-filter/token-editor.tsx 98.13% <ø> (ø)
src/tag-editor/index.tsx 90.81% <ø> (ø)
src/input/index.tsx 100.00% <100.00%> (ø)
src/input/internal.tsx 100.00% <100.00%> (ø)
...rc/internal/components/autosuggest-input/index.tsx 95.27% <100.00%> (+0.03%) ⬆️
src/multiselect/internal.tsx 97.50% <100.00%> (+0.02%) ⬆️
src/s3-resource-selector/s3-in-context/index.tsx 100.00% <100.00%> (ø)
src/select/internal.tsx 96.34% <100.00%> (+0.04%) ⬆️
src/tag-editor/internal.tsx 87.14% <100.00%> (+0.18%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avinashbot avinashbot force-pushed the fix-input-clear branch 11 times, most recently from 932b271 to 2d2dc49 Compare November 22, 2022 18:15
@avinashbot avinashbot force-pushed the fix-input-clear branch 3 times, most recently from f9b712e to 2a6a159 Compare January 2, 2023 16:03
@avinashbot avinashbot changed the title experiment: Make input clear button keyboard-accessible feat: Make clear buttons keyboard-accessible Jan 23, 2023
@Cooperbuilt
Copy link

Hey! This could be a big win for a11y in Cloudscape. Is there anything I can do to help get it over the finish line?

@avinashbot avinashbot marked this pull request as ready for review January 23, 2023 14:07
@avinashbot avinashbot requested a review from a team as a code owner January 23, 2023 14:07
@avinashbot avinashbot requested review from taheramr and removed request for a team January 23, 2023 14:07
@avinashbot avinashbot changed the title feat: Make clear buttons keyboard-accessible feat: Make clear buttons keyboard accessible Jan 23, 2023
@avinashbot avinashbot changed the title feat: Make clear buttons keyboard accessible feat: Make clear buttons keyboard-accessible Jan 23, 2023
@avinashbot avinashbot merged commit 1c5958f into main Jan 23, 2023
@avinashbot avinashbot deleted the fix-input-clear branch January 23, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants