-
Notifications
You must be signed in to change notification settings - Fork 204
fix: Keyboard navigation in area chart to allow highlighting all poin… #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 92.36% // Head: 92.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 92.36% 92.49% +0.12%
==========================================
Files 571 571
Lines 16276 16334 +58
Branches 4466 4480 +14
==========================================
+ Hits 15034 15108 +74
+ Misses 1159 1145 -14
+ Partials 83 81 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rubencarvalho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - just left a comment on one of the tests.
cd776aa to
ecf4c01
Compare
|
As per discussion with @avinashbot, removed the aria-label that I had added on the VerticalMarker, same as for the Line Chart, see #538 (comment) |
| }, | ||
| setupFilesAfterEnv: [path.join(__dirname, 'build-tools', 'jest', 'setup.js')], | ||
| testRegex: '(/__tests__/.*(\\.|/)test)\\.[jt]sx?$', | ||
| moduleFileExtensions: ['js', 'jsx', 'ts', 'tsx', 'json', 'd.ts'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary in order to test useChartModel, because it has indirect dependencies on *.d.ts files, which Jest would not be able to load otherwise.
…ts at a given X coordinate
Description
Similar to PR 538 with LineChart, this PR adds a focused state to AreaChart where all points from all series at a given X coordinate can be highlighted with the keyboard:
The specific series can then be highlighted by pressing the Up and Down keys. At the end of the array we cycle back to highlighting all points.
Related ticket: AWSUI-19257
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.