Skip to content

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Dec 6, 2022

Description

Does what it says on the tin. When the refresh wizard collapses to a 1-column view in responsive situations, everything gets shifted to the first column. This changes the column widths so that the the contents are always rendered in a minmax(0, 1fr).

Related links, issue #, if available: AWSUI-19794

How has this been tested?

Visual tests, and manual checks on all browsers. We have screenshots for this but it looks like this issue was missed.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot requested a review from a team as a code owner December 6, 2022 09:55
@avinashbot avinashbot requested review from just-boris and removed request for a team December 6, 2022 09:55
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 92.41% // Head: 92.40% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d03b5c9) compared to base (59a1797).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   92.41%   92.40%   -0.01%     
==========================================
  Files         569      571       +2     
  Lines       16235    16218      -17     
  Branches     4445     4443       -2     
==========================================
- Hits        15003    14986      -17     
  Misses       1149     1149              
  Partials       83       83              
Impacted Files Coverage Δ
src/split-panel/index.tsx 94.95% <0.00%> (-1.86%) ⬇️
src/top-navigation/parts/utility.tsx 97.22% <0.00%> (-0.08%) ⬇️
src/app-layout/index.tsx 92.30% <0.00%> (ø)
src/button-dropdown/internal.tsx 100.00% <0.00%> (ø)
src/internal/context/split-panel-context.ts 50.00% <0.00%> (ø)
src/app-layout/visual-refresh/split-panel.tsx 92.98% <0.00%> (ø)
src/split-panel/side.tsx 100.00% <0.00%> (ø)
src/split-panel/bottom.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avinashbot avinashbot merged commit 8bd54db into main Dec 6, 2022
@avinashbot avinashbot deleted the fix-firefox-table-overflow branch December 6, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants