Skip to content

Conversation

@YueyingLu
Copy link
Member

Description

component has div as child element of span.

Related links, issue AWSUI-20167

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // No change to project coverage 👍

Coverage data is based on head (68f15bc) compared to base (0c86cea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16758    16758           
  Branches     4625     4625           
=======================================
  Hits        15582    15582           
  Misses       1099     1099           
  Partials       77       77           
Impacted Files Coverage Δ
src/text-filter/internal.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YueyingLu YueyingLu marked this pull request as ready for review January 20, 2023 09:35
@YueyingLu YueyingLu requested a review from a team as a code owner January 20, 2023 09:35
@YueyingLu YueyingLu requested review from connorlanigan and removed request for a team January 20, 2023 09:35
@YueyingLu YueyingLu merged commit d52870f into main Jan 23, 2023
@YueyingLu YueyingLu deleted the textfilter-html-markup branch January 23, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants