Skip to content

Conversation

@just-boris
Copy link
Member

Reverts #658

The same issue was fixed by another PR #653. The #653 approach is preferred because it is more precisely scoped to the component which required a fix

@just-boris just-boris marked this pull request as ready for review January 24, 2023 15:20
@just-boris just-boris requested a review from a team as a code owner January 24, 2023 15:20
@just-boris just-boris requested review from connorlanigan and removed request for a team January 24, 2023 15:20
@just-boris just-boris changed the title Revert "fix: Improve HTML validity of Internal Inputs in TextFilter" revert: Improve HTML validity of Internal Inputs in TextFilter Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // No change to project coverage 👍

Coverage data is based on head (546d363) compared to base (fdaa4a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16781    16781           
  Branches     4631     4631           
=======================================
  Hits        15603    15603           
  Misses       1101     1101           
  Partials       77       77           
Impacted Files Coverage Δ
src/input/internal.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@just-boris just-boris merged commit 0d3605b into main Jan 24, 2023
@just-boris just-boris deleted the revert-658-input-container-div-to-span branch January 24, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants