Skip to content

Conversation

@YueyingLu
Copy link
Member

Description

Follow up fix of #663 to apply fix for internal & external use cases.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@YueyingLu YueyingLu marked this pull request as ready for review January 25, 2023 11:36
@YueyingLu YueyingLu requested a review from a team as a code owner January 25, 2023 11:36
@YueyingLu YueyingLu requested review from gethinwebster and removed request for a team January 25, 2023 11:36
@YueyingLu YueyingLu changed the title Fix: Intenral container without content has incorrect border radius fix: Intenral container without content has incorrect border radius Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3dfef79) compared to base (090a87d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16781    16782    +1     
  Branches     4631     4632    +1     
=======================================
+ Hits        15603    15604    +1     
  Misses       1101     1101           
  Partials       77       77           
Impacted Files Coverage Δ
src/container/index.tsx 100.00% <ø> (ø)
src/container/internal.tsx 95.74% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YueyingLu YueyingLu merged commit 23f9839 into main Jan 26, 2023
@YueyingLu YueyingLu deleted the container-without-content-fixinternal branch January 26, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants