Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

Description

Removed wrong @deprecated tag from the items property in the Flashbar component interfaces.

Without this fix, it would generate wrong documentation.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rubencarvalho rubencarvalho requested a review from a team as a code owner January 26, 2023 13:43
@rubencarvalho rubencarvalho requested review from abdhalees and removed request for a team January 26, 2023 13:43
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // No change to project coverage 👍

Coverage data is based on head (0238f7c) compared to base (23f9839).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16782    16782           
  Branches     4632     4632           
=======================================
  Hits        15604    15604           
  Misses       1101     1101           
  Partials       77       77           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubencarvalho rubencarvalho merged commit af161bb into main Jan 26, 2023
@rubencarvalho rubencarvalho deleted the fix/deprecated-flashbar-interfaces branch January 26, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants