chore: Add props reporting for D-P components #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 677 677
Lines 18275 18275
Branches 6067 6067
=======================================
+ Hits 17338 17339 +1
+ Misses 872 871 -1
Partials 65 65 ☔ View full report in Codecov by Sentry. |
jperals
approved these changes
Mar 7, 2024
| const { __internalRootRef = null } = useBaseComponent('PieChart'); | ||
| const { __internalRootRef = null } = useBaseComponent('PieChart', { | ||
| props: { | ||
| fitHeight, |
Member
There was a problem hiding this comment.
Note: this component is missing in the doc, but I see that these are the props of it that meet the given criteria.
Member
Author
There was a problem hiding this comment.
Yes, and this is not the only one missing. I fill the gaps as I go through our entire repo
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up for #2024
Related links, issue #, if available: Vg2OAA5ArJn8
How has this been tested?
PR build
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.