Skip to content

Conversation

@gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Oct 7, 2025

Description

Some adjustments to autosuggest:

  • Hide the filteringResultsText when the input text isn't being used to filter results (i.e. when first opening an autosuggest with an existing value)
  • Update the docs with more information about the filteringResultsText arguments

Related links, issue #, if available: AWSUI-61278

How has this been tested?

Updated unit tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-autosuggest-results-text branch from a8f085f to 55f85b1 Compare October 7, 2025 09:34
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (188a370) to head (55f85b1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3914   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         850      850           
  Lines       24779    24779           
  Branches     8734     8733    -1     
=======================================
  Hits        24076    24076           
- Misses        654      696   +42     
+ Partials       49        7   -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/**
* Specifies the text to display with the number of matches at the bottom of the dropdown menu while filtering.
*
* Note that the `matchesCount` includes the `enteredTextLabel` ("Use ${value}") item, so in most cases you
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately actually fixing this isn't really an option, as there are already a number of teams who do this subtraction already, so changing this behavior would be a breaking change

@gethinwebster gethinwebster requested review from a team and YueyingLu and removed request for a team and avinashbot October 8, 2025 12:50
@gethinwebster gethinwebster added this pull request to the merge queue Oct 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025
@gethinwebster gethinwebster added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit 46bf2fc Oct 9, 2025
84 of 85 checks passed
@gethinwebster gethinwebster deleted the dev-v3-gethinw-autosuggest-results-text branch October 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants