-
Notifications
You must be signed in to change notification settings - Fork 204
fix: Hide autosuggest results text when not relevant #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8f085f to
55f85b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3914 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 850 850
Lines 24779 24779
Branches 8734 8733 -1
=======================================
Hits 24076 24076
- Misses 654 696 +42
+ Partials 49 7 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /** | ||
| * Specifies the text to display with the number of matches at the bottom of the dropdown menu while filtering. | ||
| * | ||
| * Note that the `matchesCount` includes the `enteredTextLabel` ("Use ${value}") item, so in most cases you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately actually fixing this isn't really an option, as there are already a number of teams who do this subtraction already, so changing this behavior would be a breaking change
Description
Some adjustments to autosuggest:
filteringResultsTextwhen the input text isn't being used to filter results (i.e. when first opening an autosuggest with an existing value)filteringResultsTextargumentsRelated links, issue #, if available: AWSUI-61278
How has this been tested?
Updated unit tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.