Display out of sync drifts only in deep mode

[smaftoul]

Q	A
🐛 Bug fix?	yes
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues	#964
❓ Documentation	no

Description

A fix for #964.

It breaks some tests because I think the fake analysis in tests aren't created with analyzerOptions which in some tests should contain Deep: true. Other tests should probably fix the output.

Can you tell me if this approach to fix tests seems right ?

[sundowndev]

Hey @smaftoul, thanks for this first contribution! 🎉

About testing, you need to update the tests so the message only show up when deep mode is enabled. Also don't forget to set the analysis options from the Analyzer. If you need any help, feel free to join our Discord and talk with us, we'd be happy to provide some help.

[smaftoul]

About testing, you need to update the tests so the message only show up when deep mode is enabled. Also don't forget to set the analysis options from the Analyzer.

I'm not sure how I should modify tests, I think the fakeAnalysis doesn't have an Analyzer, so we cannot gather it's deepoption. Is this right ?
The tests ends up by failing all outputs and always complaining about the "out of sync" line, because it's never considered as a deep analysis.

[smaftoul]

As discussed on discord, I will add an opts argument to the fakeAnalysis() and pass it to the Analysis so it inherits the options without needing to create an Analyzer.

[sundowndev]

Thank you! 🎉

[eliecharra]

🎉 @all-contributors please add @smaftoul for code

[allcontributors]

@eliecharra

I've put up a pull request to add @smaftoul! 🎉