This repository was archived by the owner on Nov 10, 2025. It is now read-only.
fix: Correct workflow name for run_unit_evals #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to do login via things like `cmd: "node", args: ["my-node-file.js", "login"]` Also, that command will now use Zed's managed `node` instance. Release Notes: - ACP extensions can now run terminal login commands using relative paths
…ndustries#38518) On macOS, the Function key is reserved for system use and should not be used in application code. This commit updated keystroke matching and key event handling to ignore the Function key modifier while users are typing or pressing keybindings. For some keyboards with compact layout (like my 65% keyboard), there is no separated backtick key. Esc and it shares the same physical key. To input backtick, users may press `Fn-Esc`. However, macOS will still deliver events with Fn key modifier to applications. Cocoa framework can handle this correctly, which typically ignore the Fn directly. GPUI should also follow the same rule, otherwise, the backtick key on those keyboards won't work. Release Notes: - Fixed a bug where typing fn-\` on macOS would not insert a `.
…tries#36848) - On macOS, pasting now inserts the actual file path when the clipboard contains a file URL (public.file-url/public.url) - Terminal paste remains text-only; no temp files or data URLs are created. If only raw image bytes exist on the clipboard, paste is a no-op. - Scope: macOS only; no dependency changes. - Added a test (test_file_url_converts_to_path) that verifies URL→path conversion using a unique pasteboard. Release Notes: - Improved pasting on macOS: now inserts the actual file path when the clipboard contains a file URL (enables image paste support for Claude Code)
The run_unit_evals.yml workflow was incorrectly named 'run_agent_evals' due to both workflows being generated from the same module. This caused duplicate workflow names in GitHub Actions. Changes: - Updated run_agent_evals.rs to explicitly set the workflow name for run_unit_evals to 'run_unit_evals' - Regenerated workflows using 'cargo xtask workflows' - The workflow file now correctly identifies itself as 'run_unit_evals' This fixes potential CI/CD issues where GitHub Actions would be confused by duplicate workflow names.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a duplicate workflow name issue in GitHub Actions where the
run_unit_evals.ymlworkflow was incorrectly namedrun_agent_evals.Problem
The
.github/workflows/run_unit_evals.ymlfile had its workflow name set torun_agent_evalsinstead ofrun_unit_evals. This occurred because both workflow generation functions usednamed::workflow()which derives the name from the module name, causing both workflows to get the same name.Solution
tooling/xtask/src/tasks/workflows/run_agent_evals.rsto explicitly set the workflow namecargo xtask workflowsrun_unit_evalsChanges
.github/workflows/run_unit_evals.yml: Updated workflow name fromrun_agent_evalstorun_unit_evalstooling/xtask/src/tasks/workflows/run_agent_evals.rs: Explicitly set workflow nameTesting
✅ All workflow names are now unique
✅ No compilation errors or warnings
✅ YAML structure validated
This fix has also been submitted upstream to zed-industries/zed as PR zed-industries#42047.