CSV Concatenator #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
reviewed
Oct 24, 2023
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Test works. But I haven't tested the built image in docker
ddey2
approved these changes
Oct 24, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
I tested in pycharm. I had to install pandas and set Clowder_version. It works well.
Approving this. I guess we can merge once you address the other comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extractor that will try to concatenate CSV/TSV/XLSX files when uploaded to Clowder.
To test:
(there's also a Dockerfile)
Then upload two CSVs to a dataset and see that concatenated.csv is created. If you already have 2+ CSVs in the dataset and you upload a new one, all will be merged into the output. Uploading additional CSVs will update the concatenated file as it goes.
File types are currently separated, meaning CSVs will get their own merge separate from Excel etc. This would be easy to change but not sure if there's a good use case for that?
Uses pyclowder files.delete so requires this version of pyclowder: clowder-framework/pyclowder#92