Skip to content

type: give out types for boolean attributes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 11, 2022
Merged

type: give out types for boolean attributes #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
39bf95f
fix: typing
xhayper Dec 9, 2022
baec18f
fix: typing again
xhayper Dec 9, 2022
a70e58d
fix: packageManager field
xhayper Dec 9, 2022
8645981
fix: props not being accepted
xhayper Dec 9, 2022
505f0d2
chore: update pnpm
xhayper Dec 9, 2022
1a06503
fix: properly fix typing
xhayper Dec 9, 2022
bd8878c
fix: last fix
xhayper Dec 9, 2022
c33706b
feat: use .map instead of Array.from
xhayper Dec 9, 2022
0a8d1ac
remove: as any
xhayper Dec 9, 2022
b1a5a84
fix: typing yet again
xhayper Dec 9, 2022
666c4ef
remove: unnessecary as any
xhayper Dec 9, 2022
44868db
Update Component.ts
cloydlau Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"pascalCasedName": "JsonEditorVue",
"version": "0.10.2",
"private": false,
"packageManager": "pnpm@latest",
"packageManager": "pnpm@7.18.1",
"description": "JSON editor & viewer for Vue 2.6 / 2.7 / 3 & Nuxt 2 / 3.",
"author": "cloydlau",
"license": "MIT",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions src/Component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import { globalAttrs, globalProps } from './install'

export type Mode = 'tree' | 'text' | 'table'

const modelValueProp = isVue3 ? 'modelValue' : 'value'
const updateModelValue = isVue3 ? 'update:modelValue' : 'input'
const modelValueProp: any = isVue3 ? 'modelValue' : 'value'
const updateModelValue: any = isVue3 ? 'update:modelValue' : 'input'
const boolAttrs = [
'mainMenuBar',
'navigationBar',
Expand All @@ -28,19 +28,20 @@ const boolAttrs = [
'escapeControlCharacters',
'escapeUnicodeCharacters',
'flattenColumns',
]
] as const

export default defineComponent({
name,
inheritAttrs: true,
props: {
[modelValueProp]: {},
mode: {
type: String as PropType<Mode>,
},
...Object.fromEntries(Array.from(boolAttrs, boolAttr => [boolAttr, {
type: Boolean,
...(Object.fromEntries(boolAttrs.map(boolAttr => [boolAttr, {
type: Boolean as PropType<boolean>,
default: undefined,
}])),
}])) as { [key in typeof boolAttrs[number]]: { type: PropType<boolean>; default: undefined } }),
},
emits: [updateModelValue, 'update:mode'],
setup(props, { attrs, emit, expose }) {
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"resolveJsonModule": true,
"esModuleInterop": true,
"removeComments": false,
"skipLibCheck": true,
"jsx": "preserve",
"lib": ["esnext", "dom"],
"types": ["node"],
Expand Down