-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added the possibility to override the webservice location #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0378602
Added the possibility to override the webservice location to allow on…
dbc77f1
- Introduced PHP Unit as a development composer dependency
2227e8e
- Documentation/better naming for the location getter/override.
0d62b56
- Removed the dependency to PHPUnit in composer.json
a85eeac
Renamed withOverridenTarget() to withTarget() everywhere
f47c93c
Replaced one instance of shorthand array syntax use with a plain old …
425f0c7
Made a copy of the location before assigning it because __doRequest w…
91748fc
Replaced one instance of shorthand array syntax use with a plain old …
858c295
Overwriting the target of the copy instead of the original ClientEncoder
d2e13e2
Removed features that don't belong in that pull request
063dc25
Fixes tests
340426a
Renamed withTarget to withRequestTarget, fixed unit tests and code st…
pascal-hofmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this relate to the
getLocation()method (and its name)?This could also use some tests I suppose :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rename to setLocation, but thought this may be confusing because getLocation and setLocation are not really getters / setter for the same thing.
This PR adds tests in tests/FunctionalTest.php.