Skip to content

Conversation

@MrWhitezz
Copy link
Contributor

@MrWhitezz MrWhitezz commented Nov 11, 2025

Main changes made:

  • Add SimpleAbortTest which does not use primary key.
  • Update Test Names.

@skyzh
Copy link
Member

skyzh commented Nov 12, 2025

since abort test uses primary key and it's before the primary key index in the writeup, you might want to build a new test for that?

@skyzh
Copy link
Member

skyzh commented Nov 12, 2025

(there's a reason why it's at the end of the writeup in previous semesters because of the dependencies)

@MrWhitezz
Copy link
Contributor Author

since abort test uses primary key and it's before the primary key index in the writeup, you might want to build a new test for that?

Thanks for advice. Added SimpleAbortTest and Renamed the original AbortTest into AbortIndexTest.

@apavlo apavlo requested a review from skyzh November 12, 2025 22:16
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apavlo apavlo merged commit c5489dd into master Nov 12, 2025
3 checks passed
@apavlo apavlo deleted the 2025-p4-update branch November 12, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants