New indicator: test positivity and volume from DSEW Community Profile Report #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
requested changes
Nov 17, 2021
Comment on lines
+47
to
+51
| GeoMapper _is_ used to generate national figures from | ||
| state, due to architectural differences between the starred sheets and the | ||
| Overview sheet. If we discover that our nation-level figures differ too much | ||
| from those listed in the Overview sheet, we can add dedicated parsing for the | ||
| Overview sheet and remove GeoMapper from this indicator altogether. |
Contributor
There was a problem hiding this comment.
Have you thought about what the threshold for "differs too much" is? Since we have all the historical data, we can probably decide now whether or not to add dedicated national parsing so we don't have to do any backfilling later on.
Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>
* Use export_start_date / export_end_date * Correct nation aggregation for positivity as rate
Contributor
Author
|
(failing test is unrelated; due to spurious network call made by validator tests and fixed in #1458) |
harder changes spot fixes almost working
Add hospital admissions to CPR indicator
…idcast-indicators into krivard/community_profile
krivard
force-pushed
the
krivard/community_profile
branch
from
457da16 to
a58388c
Compare
nmdefries
approved these changes
Jan 19, 2022
Contributor
nmdefries
left a comment
nmdefries
left a comment
There was a problem hiding this comment.
Small suggested change to the package description but otherwise looks good!
Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This indicator generates COVID-19 test positivity and total test volume signals using the Community Profile Report (CPR) published by the Data Strategy and Execution Workgroup at https://healthdata.gov/Health/COVID-19-Community-Profile-Report/gqxm-d9w9.
The geo handling on this one is a bit different, since the CPR already includes a separate sheet for most of our geographic aggregation levels, including HHS regions, states, MSAs (a subset of CBSAs), and counties. The indicator pulls data frames from each of these sheets, rather than using our GeoMapper and risk publishing figures that don't match what was in the report.
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes