Refactor pop prop calculations to fix #1399 #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add population, replace geo, *then* divide by population. Includes test of aggregation.
krivard
commented
Dec 9, 2021
| with pytest.raises(Exception): | ||
| make_signal(data, "zig") | ||
|
|
||
| def test_pop_proportion(): |
Contributor
Author
There was a problem hiding this comment.
Note on this change, since the diffs are not helping with clarity here.
test_pop_proportion used to test two individual states as two separate asserts.
The replacement, test_transform_signal_pop, tests two geos, with both states in the first assert, and nation as the second assert.
krivard
commented
Dec 9, 2021
melange396
approved these changes
Dec 9, 2021
krivard
commented
Dec 9, 2021
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add population, replace geo, then divide by population.
Adds test of aggregation for prop signals.
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes