2088 patch nhsn #2094
Merged
2088 patch nhsn #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhkhul
reviewed
Jan 8, 2025
minhkhul
reviewed
Jan 8, 2025
minhkhul
reviewed
Jan 8, 2025
Comment on lines
+63
to
+65
| # some of the source backups do not include for preliminary data TODO remove after first patch | ||
| if not preliminary_nhsn_df.empty: | ||
| signal_df_dict.update({signal: preliminary_nhsn_df for signal in PRELIM_SIGNALS_MAP}) |
Contributor
There was a problem hiding this comment.
I'm not fully understanding what's going on here, but Is there a way to write this chunk such that we don't have to change it later?
minhkhul
reviewed
Jan 8, 2025
minhkhul
reviewed
Jan 8, 2025
Contributor
minhkhul
left a comment
minhkhul
left a comment
There was a problem hiding this comment.
Here are some doc suggestion and questions I thought of after using the code to generate a patch locally.
Co-authored-by: minhkhul <118945681+minhkhul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
patching code for nhsn