Add hsanci to nssp #2162
Merged
Add hsanci to nssp #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
reviewed
Nov 7, 2025
melange396
reviewed
Nov 7, 2025
nssp/delphi_nssp/run.py
Outdated
| elif geo == "hsanci": | ||
| df = df[["hsa_nci_id", "val", "timestamp"]] | ||
| df = df[df["hsa_nci_id"] != "All"] | ||
| df = df.groupby(["hsa_nci_id", "timestamp"])['val'].min().reset_index() |
Contributor
There was a problem hiding this comment.
The data source reports at the HSA-NCI level and duplicates the same value across the constituent counties. This picks out just one of those per key.
Contributor
There was a problem hiding this comment.
ah ok, for deduplicating. in that case, the .min() is misleading/confusing and could use a small explanatory comment
Contributor
There was a problem hiding this comment.
Fair enough. Wrote a similar comment on the epidata-etl side.
Contributor
There was a problem hiding this comment.
an alternative couldve been:
df = df.drop_duplicates()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
hsa-ncigeo level to nsspRan through extensive existing unit tests for nssp, ran the indicators and looked at the csv files. Result looks good.