Skip to content

Conversation

@chinandrew
Copy link
Collaborator

reopening now that I pulled the right commits

@chinandrew
Copy link
Collaborator Author

@capnrefsmmat check is still failing here, and I just pulled from r-pkg-devel. Anything I'm missing?

@capnrefsmmat
Copy link
Contributor

aaargh

I have R > 4.0, where stringsAsFactors = FALSE by default. CI has R 3.5, where stringsAsFactors = TRUE by default. So the data frames in the tests have factors, and the code produces strings, and... It should be easy to fix the options to disable stringsAsFactors in tests.

I have a PR I'll open momentarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants