Skip to content

Conversation

@chinandrew
Copy link
Collaborator

Partially addresses #239

Summary of changes:

  • add three tests:
    a. test that you can lag a list of signals with a list of lags
    b. test that you can lag a list of signals with a single lag vector applied to all elements
    c. test that a full join occurs when aggregating two signals with different date ranges

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@capnrefsmmat capnrefsmmat merged commit 9bd976b into r-pkg-devel Nov 25, 2020
@taylor-arnold taylor-arnold deleted the add-agg-tests branch March 19, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants