Skip to content

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 4, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

This has the exact same fix as #404, except:

  • it is based on main, not dev, so it doesn't contain the adjustAhead stuff, so we can just merge to main
  • later when we merge dev into main i think it will just notice that these commits are already in main, so it shouldn't generate conflicts; but even if it does, it'll be easy to fix

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dshemetov dshemetov requested a review from dajmcdon as a code owner October 4, 2024 18:13
@dshemetov dshemetov merged commit a3fd0f7 into main Oct 4, 2024
1 check passed
@dshemetov dshemetov deleted the ds/ci2 branch October 4, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants