Fix grouping issue in test data #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just switched this to merge into the |
|
Right, this PR probably shouldn't be the one to merge |
|
Also, I assume the merge conflicts GitHub is flagging now might automatically be resolved if #49 is merged. |
brookslogan
reviewed
Jun 15, 2022
brookslogan
reviewed
Jun 16, 2022
While `dplyr` appears to automagically provide its own `across` inside `group_by`, we still want to explicitly use `dplyr::` to - satisfy package checks, - continue to work if `dplyr` removes this magic (e.g., if the maintainers don't like this magic ignoring any user-defined/attached non-`dplyr` `across` function), and - be clear to code readers&editors where the function comes from.
brookslogan
reviewed
Jun 16, 2022
There was a problem hiding this comment.
Looks good to resolve #45. I have some other questions and comments about how the function is supposed to work, but I will add them to a separate issue.
brookslogan
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45.
Should this also be merged into the
devbranch?