Skip to content

Residual quantiles added as postprocess layer #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 22, 2022
Merged

Residual quantiles added as postprocess layer #59

merged 14 commits into from
Jun 22, 2022

Conversation

ChloeYou
Copy link
Contributor

Somehow the layer_predict unit tests are giving 3 rows instead of 108 rows. Testing if it runs properly on a virtual machine.

@ChloeYou ChloeYou requested a review from dajmcdon as a code owner June 21, 2022 01:00
@ChloeYou ChloeYou linked an issue Jun 21, 2022 that may be closed by this pull request
post_residual_quantiles #37
Closed
@ChloeYou ChloeYou changed the title testing post residual quantiles package building tests Residual quantiles added as postprocess layer Jun 21, 2022
dajmcdon
dajmcdon approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good.

I think the reason for 3 rows is because you used layer_naomit(). So this is actually as designed!

@ChloeYou After making the minor change, feel free to merge.

tests/testthat/test-layer_residual_quantile.R Outdated
latest <- get_test_data(recipe = r, x = jhu)


test_that("function works", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give this test a slightly more informative name.

@dajmcdon dajmcdon mentioned this pull request Jun 22, 2022
Closed
@ChloeYou ChloeYou merged commit b7483af into frosting Jun 22, 2022
@ChloeYou ChloeYou deleted the 37-post_residual_quantiles branch June 22, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dajmcdon dajmcdon dajmcdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

post_residual_quantiles

2 participants

@ChloeYou @dajmcdon