replace readme fig with svg, remove old stragglers #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(I also get my computer and docs: document (GHA) fighting back and forth about what the svg should look like.) |
Contributor
Author
|
(Yesh, somethiing is annoying here. I'm not quite sure what is causing the fight.) |
Contributor
|
I'm gonna rebase this to dev, since we had a merge to dev. |
dshemetov
force-pushed
the
readme-figs
branch
from
ce03c15 to
24f3dab
Compare
dshemetov
approved these changes
Jan 27, 2025
Contributor
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Looks fine, can't figure out what's causing the document action to redo the line breaks in the README (can't reproduce locally). Some lint and R CMD CHECK issues unrelated to this PR. Gonna merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
Change explanations for reviewer
See the commit message.