Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 24, 2020

closes #92

toc

@sgratzl sgratzl requested a review from tildechris November 24, 2020 21:50
@sgratzl sgratzl self-assigned this Nov 24, 2020
@netlify
Copy link

netlify bot commented Nov 24, 2020

Deploy preview for cmu-delphi-main ready!

Built with commit f6496d1

https://deploy-preview-113--cmu-delphi-main.netlify.app

@tildechris
Copy link
Contributor

This is amazing. Only one problem is that the TOC overflows the blog content at the bottom of the page:

image

@sgratzl sgratzl added this to the Site Design V2 milestone Nov 25, 2020
@tildechris
Copy link
Contributor

Sam, if we can fix that overflow issue I think we can pull this into the redesign. Thoughts?

@sgratzl
Copy link
Member Author

sgratzl commented Nov 25, 2020

was easier than expected to fix: https://getuikit.com/docs/sticky#bottom

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam, this works great. LGTM.

@sgratzl sgratzl merged commit da5d084 into dev Nov 25, 2020
@sgratzl sgratzl deleted the sgratzl/blog-toc branch November 25, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants