Header / Footer #26

kateharwood · 2020-11-12T19:12:38Z

First pass at navbar.

@Letsgohyde still need to add in the real icons (and definitely need a better version of the logo, I'm just using the favicon currently)

Also, does not play well with mobile / is not responsive yet. What are our plans regarding mobile and responsiveness for this iteration? Do we have separate designs?

netlify · 2020-11-12T19:13:09Z

Deploy preview for cmu-delphi-main ready!

Built with commit 255fc1e

https://deploy-preview-26--cmu-delphi-main.netlify.app

kateharwood · 2020-11-13T19:38:33Z

Added footer

kateharwood · 2020-11-13T21:50:26Z

Header updated:

tildechris · 2020-11-17T16:04:09Z

static/font-awesome/api.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 384 512"><!-- Font Awesome Free 5.15.1 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) --><path d="M384 144c0-44.2-35.8-80-80-80s-80 35.8-80 80c0 36.4 24.3 67.1 57.5 76.8-.6 16.1-4.2 28.5-11 36.9-15.4 19.2-49.3 22.4-85.2 25.7-28.2 2.6-57.4 5.4-81.3 16.9v-144c32.5-10.2 56-40.5 56-76.3 0-44.2-35.8-80-80-80S0 35.8 0 80c0 35.8 23.5 66.1 56 76.3v199.3C23.5 365.9 0 396.2 0 432c0 44.2 35.8 80 80 80s80-35.8 80-80c0-34-21.2-63.1-51.2-74.6 3.1-5.2 7.8-9.8 14.9-13.4 16.2-8.2 40.4-10.4 66.1-12.8 42.2-3.9 90-8.4 118.2-43.4 14-17.4 21.1-39.8 21.6-67.9 31.6-10.8 54.4-40.7 54.4-75.9zM80 64c8.8 0 16 7.2 16 16s-7.2 16-16 16-16-7.2-16-16 7.2-16 16-16zm0 384c-8.8 0-16-7.2-16-16s7.2-16 16-16 16 7.2 16 16-7.2 16-16 16zm224-320c8.8 0 16 7.2 16 16s-7.2 16-16 16-16-7.2-16-16 7.2-16 16-16z"/></svg>


Instead of checking these in, can you pull them down from npm?

Let's handle this in another PR.

tildechris

LGTM, thanks Kate!

sgratzl

can you resolve the conflicts, please

Moreover, can you use relative links otherwise it won't work on our test environment

sgratzl · 2020-11-17T19:09:28Z

config.toml

-    name = "Delphi"
+    identifier = "about"
+    name = "About"
    url = "https://delphi.cmu.edu/"


please use a relative link here /about isn't it?

Hmm I'm not sure if matching the active url to these urls to highlight active tab will work if these are changed to be relative, might have to rethink that then if it's important to make these relative.

sgratzl · 2020-11-17T19:10:00Z

config.toml

 [[menu.main]]
    name = "COVIDcast"
+    pre = "map"
    url = "https://covidcast.cmu.edu"


will soon be /covidcast

sgratzl · 2020-11-17T19:10:11Z

config.toml

 [[menu.main]]
    name = "Blog"
+    pre = "blog"
    url = "https://delphi.cmu.edu/blog"


same here /blog

sgratzl · 2020-11-17T19:11:21Z

themes/delphi/layouts/partials/delphi-text-logo.html

@@ -0,0 +1 @@
+<a class="delphi-text-logo" href="https://delphi.cmu.edu/">DELPHI</a>


see https://gohugo.io/functions/relref/ to create references in hugo

How do you use this to link to the homepage from anywhere on the site? Relref seems to be relative to where the user is on the site? Definitely not understanding something here.

sgratzl · 2020-11-17T19:13:46Z

themes/delphi/layouts/partials/footer/desktop.html

+    <table class="uk-table footer-table">
+        <thead>
+            <tr>
+                <th class="header">


should we prefix css classnames by their area?, e.g. footer-header?

sgratzl · 2020-11-17T19:14:35Z

themes/delphi/layouts/partials/head.html

+    <link rel="preconnect" href="https://fonts.gstatic.com">
+    <link href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@300&display=swap" rel="stylesheet">
+    <link href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@600&display=swap" rel="stylesheet">
+    <link href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@700&display=swap" rel="stylesheet">


is it possible to load all fonts at one?

sgratzl · 2020-11-17T19:19:04Z

themes/delphi/layouts/partials/nav.html

+        </li>
+        {{ $currentPage := . }}
+        {{ range .Site.Menus.main.ByWeight }}
+        <li class="{{ if (eq $currentPage.URL .URL) }}active{{ end }}">


have you tried using https://gohugo.io/functions/hasmenucurrent/? instead

Yes, that wasn't working for me, and I looked at some other posts and saw that it seems not to work without putting the menu items in the "Front Matter" for the pages, and I saw this used as a workaround

tildechris

LGTM.

kateharwood added 3 commits November 11, 2020 15:14

first pass at header

58ae81a

Merge branch 'dev' into header

e30fb96

first pass header

77f6955

kateharwood added 2 commits November 12, 2020 14:14

removing changes to variable scss file

8cd0760

adding footer

5f415ce

kateharwood changed the title ~~Navbar~~ Navbar / Footer Nov 13, 2020

kateharwood changed the title ~~Navbar / Footer~~ Header / Footer Nov 13, 2020

adding font awesome icons

8406c74

tildechris requested review from sgratzl and tildechris November 16, 2020 20:31

tildechris suggested changes Nov 17, 2020

View reviewed changes

kateharwood added 3 commits November 17, 2020 13:53

responsive nav and other tweaks

f29cc8f

updating svg fill

007dd95

remove center of excellence

e0f8743

tildechris approved these changes Nov 17, 2020

View reviewed changes

kateharwood marked this pull request as ready for review November 17, 2020 19:01

sgratzl reviewed Nov 17, 2020

View reviewed changes

kateharwood added 4 commits November 17, 2020 16:28

addressing PR comments

b5b1752

resolving merge conflicts

5640675

resolving merge conflicts

c4db8bf

fixing build error

255fc1e

tildechris self-requested a review November 17, 2020 21:51

tildechris approved these changes Nov 17, 2020

View reviewed changes

kateharwood merged commit a734a27 into dev Nov 17, 2020

sgratzl deleted the header branch November 23, 2020 19:54

		@@ -0,0 +1 @@
		<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 384 512"><!-- Font Awesome Free 5.15.1 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) --><path d="M384 144c0-44.2-35.8-80-80-80s-80 35.8-80 80c0 36.4 24.3 67.1 57.5 76.8-.6 16.1-4.2 28.5-11 36.9-15.4 19.2-49.3 22.4-85.2 25.7-28.2 2.6-57.4 5.4-81.3 16.9v-144c32.5-10.2 56-40.5 56-76.3 0-44.2-35.8-80-80-80S0 35.8 0 80c0 35.8 23.5 66.1 56 76.3v199.3C23.5 365.9 0 396.2 0 432c0 44.2 35.8 80 80 80s80-35.8 80-80c0-34-21.2-63.1-51.2-74.6 3.1-5.2 7.8-9.8 14.9-13.4 16.2-8.2 40.4-10.4 66.1-12.8 42.2-3.9 90-8.4 118.2-43.4 14-17.4 21.1-39.8 21.6-67.9 31.6-10.8 54.4-40.7 54.4-75.9zM80 64c8.8 0 16 7.2 16 16s-7.2 16-16 16-16-7.2-16-16 7.2-16 16-16zm0 384c-8.8 0-16-7.2-16-16s7.2-16 16-16 16 7.2 16 16-7.2 16-16 16zm224-320c8.8 0 16 7.2 16 16s-7.2 16-16 16-16-7.2-16-16 7.2-16 16-16z"/></svg> No newline at end of file

		@@ -0,0 +1 @@
		<a class="delphi-text-logo" href="https://delphi.cmu.edu/">DELPHI</a> No newline at end of file

Header / Footer #26

Header / Footer #26

Uh oh!

Conversation

kateharwood commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kateharwood commented Nov 13, 2020

Uh oh!

kateharwood commented Nov 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tildechris left a comment

Choose a reason for hiding this comment

Uh oh!

sgratzl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tildechris left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kateharwood commented Nov 12, 2020 •

edited

Loading

netlify bot commented Nov 12, 2020 •

edited

Loading