Debug: 1. cache refresh at every init; 2. compute cardinality only once #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs solved:
SkeletonDiscovery.py:L145(for PC) andFCI.py:L615(for FCI).hash(data.tobytes())- it's slow. @chenweiDelight also mentions a fasterhash(str(data))- but let's just init refresh and use no hash.cardinalitiesandis_discreteatFas.py:L10, and calculate cardinalities only once atSkeletonDiscovery.py:L165(for PC) andFCI.py:L625(for FCI). No need tonp.max()every time.TODO: still debugging:
Now PC results with/without fas (change
PC.py:L71) respectively:time (sec)
So two problems:
child.andes26s vs 45s - though before solving cardinalities issue, it's ~300s.