specs-go: fix minumum version check for IntelRdt.

[klihub]

This slipped through our review...

Add minimum version check unit test for IntelRdt. Fix check to require 1.1.0 if at least one of the global or device specific container edits use IntelRdt.

[bart0sh]

I can see this nested loop in other places as well. Would it make sense to wrap it in function?

[klihub]

You mean something like

// ForeachSpec iterates through all Specs by vendor, calling the given
// callback function for every Spec. It stops iterating early if the function
// returns true.
func ForeachSpec(fn func(spec *cdi.Spec) bool) {
    for _, v := range cache.ListVendors() {
        for _, s := range cache.GetVendorSpecs(v) {
            done := fn(s)
            if done {
                return
            } 
        }
    }
}

I'm fine doing that, but if we decide so then let's do it in a separate PR.

[bart0sh]

Yes, this is what I was thinking about. I'm ok with doing it in a separate PR if you think it makes sense to do.

[bart0sh]

/lgtm

[marquiz]

Thanks @klihub

How's the netdevice stuff related to this? Shouldn't those be a separate PR (or then adjust the PR title and summary accordingly)?

nit: one commit message title s/minumum/minimum/

[elezar]

Good catch @klihub. Thanks.

[klihub]

Thanks @klihub

How's the netdevice stuff related to this? Shouldn't those be a separate PR (or then adjust the PR title and summary accordingly)?

@marquiz Argh, it is not related otherwise than me having those stacked on the same branch because they need to touch the same function in specs-go/version.go. I just I accidentally pushed the full commit stack to this branch, too. Fixed that now.

nit: one commit message title s/minumum/minimum/

Thanks for spotting it. Fixed that one, too.